Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone: Enable Material You Pill icon in Notification Bar #53

Open
ZanzDroid opened this issue Jan 25, 2023 · 5 comments
Open

Phone: Enable Material You Pill icon in Notification Bar #53

ZanzDroid opened this issue Jan 25, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ZanzDroid
Copy link

Summary

For a while, a call in-progress showed up as a Pill or Tidepod in the notification bar, and had a different appearance in the notification dropdown. Currently, there is a floating avatar for calls in progress. The incoming call popup-up interface also looked cleaner.

Solution

Re-enable the notification bar "Pill" icon, and the newer (Android 12+) interface for incoming, and ongoing calls.

Examples

The first two images show the difference in the pop-up notification for incoming calls. I prefer the newer method where the answer & hang-up buttons are icons, rather than the partial words with "...". The last three images show two with the floating avatar, and one with the pill icon in the notification bar. Currently the Phone app is using the style I don't like.

Alternatives

I would like if the DialerMod could give a choice of which interface to use, and modify the phenotype.db database accordingly.

Context

2022-10-17 19 00 13
2022-08-29 21 08 26
2022-08-30 11 36 01
2022-08-30 11 36 08
2022-10-17 18 03 30

It looks much cleaner. It was enabled in late 2021, then removed for a number of months. It returned briefly in late 2022, then mysteriously disappeared again. The floating avatar for ongoing calls is annoying, as is the pop-up when there is an incoming call. I know both are available in the Phone app, because for a month or two it showed up on one of my Pixel phones, but not the other. Both were Pixel 6 phones, running the same version of the Google Phone app.

@ZanzDroid ZanzDroid added the enhancement New feature or request label Jan 25, 2023
@jacopotediosi
Copy link
Owner

jacopotediosi commented Jan 25, 2023

The enable_android_s_notifications flag seems a good start
@ZanzDroid

@ZanzDroid
Copy link
Author

@jacopotediosi

That seems to have done the trick. Thank you!

@fillwithjoy1
Copy link

Should this be closed for inactivity?

@jacopotediosi
Copy link
Owner

Should this be closed for inactivity?

I'm keeping this open as a reminder for myself, to eventually implement a suggested mod for that flag.

Currently, I'm rewriting locally a major part of the codebase (migrating the sqlite things to a libsu RootService, moving fragments operations to async threads, etc). Please don't expect new features until then, because this work is needed if we want to support multiple Google Apps other than the dialer, which is my priority right now.
Given I'm not an android developer, I'm learning how to code all of this, and the complexity here is high (e.g., not all apps in the world needs to edit files outside their data folder), so expect long delays.

@fillwithjoy1
Copy link

Should this be closed for inactivity?

I'm keeping this open as a reminder for myself, to eventually implement a suggested mod for that flag.

Currently, I'm rewriting locally a major part of the codebase (migrating the sqlite things to a libsu RootService, moving fragments operations to async threads, etc). Please don't expect new features until then, because this work is needed if we want to support multiple Google Apps other than the dialer, which is my priority right now. Given I'm not an android developer, I'm learning how to code all of this, and the complexity here is high (e.g., not all apps in the world needs to edit files outside their data folder), so expect long delays.

Gotcha. I might make a pull request but I haven't really worked with Java 😅

@jacopotediosi jacopotediosi changed the title Enable Material You Pill icon in Notification Bar Phone: Enable Material You Pill icon in Notification Bar May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants