Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments not visible #229

Closed
hrishikesh-k opened this issue Apr 4, 2018 · 5 comments
Closed

Comments not visible #229

hrishikesh-k opened this issue Apr 4, 2018 · 5 comments

Comments

@hrishikesh-k
Copy link

hrishikesh-k commented Apr 4, 2018

I'm setting up HashOver on my (I'm developing it, but, the blog is actually of my friend) new website (blog, rather). The URL is: htps://www.brokenhearts.ml/

I'm using Adobe Muse to develop the website and I have hosted it on InfinityFree.

The only changes I've made to the code is the CSS; replaced every (5, in total) #hashover-end-links with

#hashover-end-links {
    display: none;
}

I read one whole thread about the license stuff, but, my friend doesn't want the links at all, so, had to do it.

But now, I can't see the comments which were visible before the change. See here: htps://www.brokenhearts.ml/breakups.html Only the names of the posters are visible.

What can be the problem?

Also, is there any way in which I can display same comments on 2 different pages? I mean, Adobe Muse creates a seperate webpage for the mobile and tablet version in my case. So, users are redirected from https://www.brokenhearts.ml/index.html to https://www.brokenhearts.ml/phone/index.html and https://www.brokenhearts.ml/tablet/index.html when visited from mobile and tablet devices respectively. So, I think that HashOver will create seperate comment directory for each of the 'same' page. Thus, users will see different comments on desktop, mobile and tablet users. Any way to keep all the 'same' pages with same comments?

@jacobwb
Copy link
Owner

jacobwb commented Apr 4, 2018

Thank you for reading through the issues before opening a new one.

It would seem you misunderstood this thread, but only slightly.

I notice two problems with the CSS at: brokenhearts.ml/hashover/themes/default/comments.css

The first is that there are two copies of the CSS in the file, as if you pasted the CSS at the end of the file.

Note the second Copyright notice halfway through the file.

The second is this change:

.hashover .hashover-comment > .hashover-balloon,
+.hashover .hashover-edit-form,
+.hashover #hashover-end-links {
+    display: none;
+}
.hashover .hashover-border-top {
	border-top: 1px solid #AAAAAA;
}

This hides the "comment balloon" -- where the comment itself is displayed -- and it also removes the top border of the comment balloon. It sounds like neither of these things is what you want.

I would start over. Replace /hashover/themes/default/comments.css with the original file.

And then make this simple change on line 1108:

.hashover #hashover-end-links {
+	display: none;
	margin-top: -12px;
	padding: 18px 0px 5px 0px;
	text-align: center;
}

Just in case you aren't familiar with diffs, simply add the green line (without the "+").

@jacobwb
Copy link
Owner

jacobwb commented Apr 4, 2018

As to your other question.

HashOver will respect a canonical link element in the page head.

Both of these pages:

https://www.brokenhearts.ml/phone/breakups.html
https://www.brokenhearts.ml/tablet/breakups.html

Have this canonical link element:

<link rel="canonical" href="https://www.brokenhearts.ml/breakups.html" />

Meaning both of those pages will be treated as the same page as:

https://www.brokenhearts.ml/breakups.html

All three pages should all display the same thread.

As long as any other pages do this same thing, you shouldn't have any problems.

If you find that this isn't the case, and that the pages get different threads, that would be a bug and I would appreciate if you would report it as a separate issue.

@hrishikesh-k
Copy link
Author

Yeah. The balloon issue got fixed.

And, by now, I have figured out how to make proper responsive websites in Muse. So, I won't need the canonical thing.

However, Bold and italic formatting isn't working for me. Others are working. What can be the problem with it?

@CyberShadow
Copy link
Contributor

However, Bold and italic formatting isn't working for me. Others are working. What can be the problem with it?

It's because the default CSS rules for strong and em are disabled in your site_global.css:

address,caption,cite,code,dfn,em,strong,th,var,optgroup{font-style:inherit;font-weight:inherit;}

@hrishikesh-k
Copy link
Author

@CyberShadow

Thank you sir. That worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants