FTBFS with MariaDB 10.3 (Debian)

[fauust]

Hi,
I am filling this issue, to link it to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917758 and to be sure that upstream dev are aware of it.

As explained by Sergei (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919395#36)

error: 'MYSQL' {aka 'struct st_mysql'} has no member named 'reconnect'

This is not a bug. MYSQL.reconnect was not part of the API, even in 5.5
https://dev.mysql.com/doc/refman/5.5/en/c-api-auto-reconnect.html

Regards,
Faustin

[ottok]

Relevant part (hopefully):

make[3]: Entering directory '/<>/storage'
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -DLIBRARY_DIR="/usr/lib/x86_64-linux-gnu/jabberd2" -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o libstorage_la-storage.lo test -f 'storage.c' || echo './'storage.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -DLIBRARY_DIR="/usr/lib/x86_64-linux-gnu/jabberd2" -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o libstorage_la-object.lo test -f 'object.c' || echo './'object.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o authreg_anon.lo authreg_anon.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o authreg_db.lo authreg_db.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o storage_db.lo storage_db.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o storage_fs.lo storage_fs.c
�[01m�[Kstorage_fs.c:�[m�[K In function '�[01m�[K_st_fs_put�[m�[K':
�[01m�[Kstorage_fs.c:173:64:�[m�[K �[01;35m�[Kwarning: �[m�[Kcast from pointer to integer of different size [�[01;35m�[K-Wpointer-to-int-cast�[m�[K]
fprintf(f, "%s %d %d\n", key, ot, (�[01;35m�[K(�[m�[Kint)val != 0) ? 1 : 0);
�[01;35m�[K^�[m�[K
�[01m�[Kstorage_fs.c:177:63:�[m�[K �[01;35m�[Kwarning: �[m�[Kcast from pointer to integer of different size [�[01;35m�[K-Wpointer-to-int-cast�[m�[K]
fprintf(f, "%s %d %d\n", key, ot, �[01;35m�[K(�[m�[Kint) val);
�[01;35m�[K^�[m�[K
�[01m�[Kstorage_fs.c:�[m�[K In function '�[01m�[K_st_fs_delete�[m�[K':
�[01m�[Kstorage_fs.c:383:34:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[K%s�[m�[K' directive output may be truncated writing up to 255 bytes into a region of size between 0 and 1023 [�[01;35m�[K-Wformat-truncation=�[m�[K]
snprintf(file, 1024, "%s/�[01;35m�[K%s�[m�[K", path, dirent->d_name);
�[01;35m�[K^~�[m�[K
In file included from �[01m�[K/usr/include/stdio.h:873�[m�[K,
from �[01m�[K../util/util.h:27�[m�[K,
from �[01m�[Kstorage.h:38�[m�[K,
from �[01m�[Kstorage_fs.c:36�[m�[K:
�[01m�[K/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10:�[m�[K �[01;36m�[Knote: �[m�[K'�[01m�[K__builtin___snprintf_chk�[m�[K' output between 2 and 1280 bytes into a destination of size 1024
return �[01;36m�[K__builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,�[m�[K
�[01;36m�[K^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[m�[K
�[01;36m�[K __bos (__s), __fmt, __va_arg_pack ())�[m�[K;
�[01;36m�[K~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[m�[K
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o authreg_ldap.lo authreg_ldap.c
�[01m�[Kstorage_fs.c:�[m�[K In function '�[01m�[K_st_fs_get�[m�[K':
�[01m�[Kstorage_fs.c:239:34:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[K%s�[m�[K' directive output may be truncated writing up to 255 bytes into a region of size between 0 and 1023 [�[01;35m�[K-Wformat-truncation=�[m�[K]
snprintf(file, 1024, "%s/�[01;35m�[K%s�[m�[K", path, dirent->d_name);
�[01;35m�[K^~�[m�[K
In file included from �[01m�[K/usr/include/stdio.h:873�[m�[K,
from �[01m�[K../util/util.h:27�[m�[K,
from �[01m�[Kstorage.h:38�[m�[K,
from �[01m�[Kstorage_fs.c:36�[m�[K:
�[01m�[K/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10:�[m�[K �[01;36m�[Knote: �[m�[K'�[01m�[K__builtin___snprintf_chk�[m�[K' output between 2 and 1280 bytes into a destination of size 1024
return �[01;36m�[K__builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,�[m�[K
�[01;36m�[K^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[m�[K
�[01;36m�[K __bos (__s), __fmt, __va_arg_pack ())�[m�[K;
�[01;36m�[K~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[m�[K
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o authreg_ldapfull.lo authreg_ldapfull.c
�[01m�[Kauthreg_ldapfull.c:�[m�[K In function '�[01m�[K_ldapfull_chk_crypt�[m�[K':
�[01m�[Kauthreg_ldapfull.c:463:17:�[m�[K �[01;35m�[Kwarning: �[m�[Kimplicit declaration of function '�[01m�[Kcrypt�[m�[K'; did you mean '�[01m�[Kcreat�[m�[K'? [�[01;35m�[K-Wimplicit-function-declaration�[m�[K]
encrypted = �[01;35m�[Kcrypt�[m�[K(passwd, salt);
�[01;35m�[K^~~~~�[m�[K
�[32m�[Kcreat�[m�[K
�[01m�[Kauthreg_ldapfull.c:463:15:�[m�[K �[01;35m�[Kwarning: �[m�[Kassignment to '�[01m�[Kconst char *�[m�[K' from '�[01m�[Kint�[m�[K' makes pointer from integer without a cast [�[01;35m�[K-Wint-conversion�[m�[K]
encrypted �[01;35m�[K=�[m�[K crypt(passwd, salt);
�[01;35m�[K^�[m�[K
�[01m�[Kauthreg_ldapfull.c:�[m�[K In function '�[01m�[K_ldapfull_set_crypt�[m�[K':
�[01m�[Kauthreg_ldapfull.c:487:15:�[m�[K �[01;35m�[Kwarning: �[m�[Kassignment to '�[01m�[Kconst char *�[m�[K' from '�[01m�[Kint�[m�[K' makes pointer from integer without a cast [�[01;35m�[K-Wint-conversion�[m�[K]
encrypted �[01;35m�[K=�[m�[K crypt(passwd, salt);
�[01;35m�[K^�[m�[K
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o storage_ldapvcard.lo storage_ldapvcard.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/mariadb -I/usr/include/mariadb/mysql -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o authreg_mysql_la-authreg_mysql.lo test -f 'authreg_mysql.c' || echo './'authreg_mysql.c
/bin/bash ../libtool --quiet --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/mariadb -I/usr/include/mariadb/mysql -Wdate-time -D_FORTIFY_SOURCE=2 -I../c2s -I.. -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -funsigned-char -fdiagnostics-color -c -o storage_mysql_la-storage_mysql.lo test -f 'storage_mysql.c' || echo './'storage_mysql.c
�[01m�[Kauthreg_mysql.c:�[m�[K In function '�[01m�[K_ar_mysql_set_password�[m�[K':
�[01m�[Kauthreg_mysql.c:243:26:�[m�[K �[01;35m�[Kwarning: �[m�[Kimplicit declaration of function '�[01m�[Kcrypt�[m�[K'; did you mean '�[01m�[Kbcrypt�[m�[K'? [�[01;35m�[K-Wimplicit-function-declaration�[m�[K]
strcpy(password, �[01;35m�[Kcrypt�[m�[K(password, salt));
�[01;35m�[K^~~~~�[m�[K
�[32m�[Kbcrypt�[m�[K
�[01m�[Kauthreg_mysql.c:243:26:�[m�[K �[01;35m�[Kwarning: �[m�[Kpassing argument 2 of '�[01m�[Kstrcpy�[m�[K' makes pointer from integer without a cast [�[01;35m�[K-Wint-conversion�[m�[K]
strcpy(password, �[01;35m�[Kcrypt(password, salt)�[m�[K);
�[01;35m�[K^~~~~~~~~~~~~~~~~~~~~�[m�[K
In file included from �[01m�[K/usr/include/features.h:424�[m�[K,
from �[01m�[K/usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33�[m�[K,
from �[01m�[K/usr/include/stdlib.h:25�[m�[K,
from �[01m�[K/usr/include/expat.h:45�[m�[K,
from �[01m�[K../c2s/c2s.h:25�[m�[K,
from �[01m�[Kauthreg_mysql.c:24�[m�[K:
�[01m�[K/usr/include/x86_64-linux-gnu/bits/string_fortified.h:88:1:�[m�[K �[01;36m�[Knote: �[m�[Kexpected '�[01m�[Kconst char * restrict�[m�[K' but argument is of type '�[01m�[Kint�[m�[K'
�[01;36m�[K__NTH�[m�[K (strcpy (char *__restrict __dest, const char *__restrict __src))
�[01;36m�[K^~~~~�[m�[K
�[01m�[Kauthreg_mysql.c:�[m�[K In function '�[01m�[K_ar_mysql_check_password�[m�[K':
�[01m�[Kauthreg_mysql.c:296:28:�[m�[K �[01;35m�[Kwarning: �[m�[Kassignment to '�[01m�[Kchar *�[m�[K' from '�[01m�[Kint�[m�[K' makes pointer from integer without a cast [�[01;35m�[K-Wint-conversion�[m�[K]
crypted_pw �[01;35m�[K=�[m�[K crypt(password,db_pw_value);
�[01;35m�[K^�[m�[K
�[01m�[Kauthreg_mysql.c:�[m�[K In function '�[01m�[Kar_init�[m�[K':
�[01m�[Kauthreg_mysql.c:631:9:�[m�[K �[01;31m�[Kerror: �[m�[K'�[01m�[KMYSQL�[m�[K' {aka '�[01m�[Kstruct st_mysql�[m�[K'} has no member named '�[01m�[Kreconnect�[m�[K'
conn�[01;31m�[K->�[m�[Kreconnect = 1;
�[01;31m�[K^~�[m�[K
�[01m�[Kstorage_mysql.c:�[m�[K In function '�[01m�[Kst_init�[m�[K':
�[01m�[Kstorage_mysql.c:616:9:�[m�[K �[01;31m�[Kerror: �[m�[K'�[01m�[KMYSQL�[m�[K' {aka '�[01m�[Kstruct st_mysql�[m�[K'} has no member named '�[01m�[Kreconnect�[m�[K'
conn�[01;31m�[K->�[m�[Kreconnect = 1;
�[01;31m�[K^~�[m�[K
make[3]: *** [Makefile:827: authreg_mysql_la-authreg_mysql.lo] Error 1

[ottok]

Looks like the same bug affects MySQL 8.0 as well: #192

[fauust]

@ottok they seems to have terminal coloration for the log output (which is pretty but makes it difficult to read on non-terminal).

Here are the relevant lines cleaned with sed (I guess):
$ wget -q -O- "http://aws-logs.debian.net/2018/12/29/jabberd2_2.6.1-3_unstable.log" | sed -r "s/\x1B\[([0-9]{1,2}(;[0-9]{1,2})?)?[m|K]//g"

authreg_mysql.c: In function 'ar_init':
authreg_mysql.c:631:9: error: 'MYSQL' {aka 'struct st_mysql'} has no member named 'reconnect'
conn->reconnect = 1;
^~
storage_mysql.c: In function 'st_init':
storage_mysql.c:616:9: error: 'MYSQL' {aka 'struct st_mysql'} has no member named 'reconnect'
conn->reconnect = 1;
^~