Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling and management #88

Open
snkas opened this issue Jul 3, 2014 · 0 comments
Open

Error handling and management #88

snkas opened this issue Jul 3, 2014 · 0 comments

Comments

@snkas
Copy link
Contributor

snkas commented Jul 3, 2014

While testing, I was really struggeling with the question 'To what extent should this API be demanding/defensive?'

Currently (in my fork) the Comments/Submissions/Subreddits classes have minimal preconditions for the arguments, with only throwing a IllegalArgumentException if one of the arguments is totally invalid (like a null when retrieval submissions of a subreddit).

But for example you receive a 403 when trying to retrieve submissions, should this result in a null, an empty list of submissions or an exception PermissionDeniedException? And should these be Runtime or Static exceptions? Any thoughts guys? @karan ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants