You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think every User instance should create and maintain its own RestClient. An outside user shouldn't be responsible for passing one in; that's an implementation detail.
I also want to note that the examples in the README don't pass in a RestClient, but as it currently stands the code requires it.
The text was updated successfully, but these errors were encountered:
@JamesGold23 we intend to create a wrapper over all the functionality, something like a jReddit class, which will eventually be used by the end-user. They will have access to all the functionality of the library through that class, so they won't have to bother with such things as creating rest clients and passing them wherever needed.
I think that will resolve this issue, although I somewhat agree with you. On the other hand, as the current implementation stands, it's more of a overhead to create and maintain restClient instances throughout the application, as not only the User class uses it, and this will create too many unneeded and redundant objects. Moreover, we shouldn't code for this if we plan on creating the wrapper.
I think every User instance should create and maintain its own RestClient. An outside user shouldn't be responsible for passing one in; that's an implementation detail.
I also want to note that the examples in the README don't pass in a RestClient, but as it currently stands the code requires it.
The text was updated successfully, but these errors were encountered: