Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiCam support #65

Closed
PRGeno opened this issue Oct 3, 2019 · 7 comments
Closed

MultiCam support #65

PRGeno opened this issue Oct 3, 2019 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects

Comments

@PRGeno
Copy link

PRGeno commented Oct 3, 2019

You have made so much progress in such a short time. Great job on a real nice addition to OctoPrint.

I love that you added support for a webcam. Would consider adding support for a second like what the MultiCam plugin has done? I use MultiCam with front and rear view cameras to toggle between them to keep an eye how things are progressing. It's just a second http address and a way to toggle between them.

Thanks for your consideration and thanks for Dashboard as well.

@StefanCohen
Copy link
Collaborator

I do have a second webcam so I will keep this one for a rainy day but I have some things I want to do before this.

@StefanCohen StefanCohen added the enhancement New feature or request label Oct 3, 2019
@PRGeno
Copy link
Author

PRGeno commented Oct 5, 2019

That would be great if it could be done. If I can add one more wish to this. If possible please support the "Fullscreen Plugin" from Paul de Vries as well so double clicking on the webcam image will expand it to the full size of the browser, just like it would from the "Control" tab. This allows for a quick zoom in look at what's happening.

I'm enjoying your plug in and really appreciate you sharing it with the rest of us.

@StefanCohen StefanCohen added this to To do in TODOs Oct 8, 2019
@Kizan
Copy link

Kizan commented Jan 29, 2020

I would very much like to have multi-cam support.

Thanks for this great plugin!

@StefanCohen
Copy link
Collaborator

Update: I'm will not actively work on this feature but will happily review a PR if provided.

@StefanCohen StefanCohen added the help wanted Extra attention is needed label Mar 8, 2020
@StefanCohen
Copy link
Collaborator

@PRGeno I looked into the possibility to support the FullScreen plugin today but there is unfortunately nothing i can do on my end to make that plugin work together with the dashboard. The reason is that FullScreen is hard-coded to look for a specific set of element IDs on the control tab that I can't hijack without breaking the control tab.

@PRGeno
Copy link
Author

PRGeno commented Apr 2, 2020

@StefanCohen Thanks for giving it a shot. Love your work and how great Dashboard has evolved.

@StefanCohen
Copy link
Collaborator

This has been implemented in v1.13.0 thanks to a patch provided by the user CynanX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
TODOs
  
To do
Development

No branches or pull requests

3 participants