Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full screen mode #38

Closed
Ha-Z-Z-ard opened this issue Sep 21, 2019 · 17 comments
Closed

Full screen mode #38

Ha-Z-Z-ard opened this issue Sep 21, 2019 · 17 comments
Assignees
@StefanCohen
Labels
enhancement New feature or request
Milestone
1.4.0

Comments

@Ha-Z-Z-ard
Copy link

Is your feature request related to a problem? Please describe.
no problem,is it possable to have the dashboard within its own frame,so this could be made fullscreen?

Describe the solution you'd like
fullscreen dashboard for a " info screen full display" with setups that have screens for there printers

Describe alternatives you've considered
just learning code and alterntives are beyond my current expertise
@StefanCohen StefanCohen added this to the 1.4.0 milestone Sep 21, 2019
@StefanCohen StefanCohen added the enhancement New feature or request label Sep 21, 2019
@StefanCohen StefanCohen self-assigned this Sep 21, 2019
@StefanCohen
Copy link
Collaborator

Ok. I have added a setting for enabling fullscreen mode (experimental for now) in the next release. I haven't made any attempt to style it differently if in fullscreen yet. I think the layout should be adjusted significantly when in fullscreen, but my css-fu is very limited, so let's see if you or anybody else would like to contribute some styling.

@Ha-Z-Z-ard
Copy link
Author

Ha-Z-Z-ard commented Sep 21, 2019 via email

@chadlichty
Copy link

This is great. One issue I saw was the webCam was cropped in full-screen mode. That issue is fixed in the regular display. Looks great though.

@StefanCohen
Copy link
Collaborator

I know. The webcam issue is however technically different than the one in 1.2.0 and can be solved by restyling the view in fullscreen.
The fullscreen mode could benefit from a different layout where the cam and dash resides side by side horizontally or maybe overlaid on eachother.

@Ha-Z-Z-ard
Copy link
Author

Ha-Z-Z-ard commented Sep 21, 2019 via email

@StefanCohen
Copy link
Collaborator

It is certainly possible to combine the views.Consolidate Temp Control does something similar: https://github.com/jneilliii/OctoPrint-ConsolidateTempControl

But I'm not sure I want to go that route. I think Less is more and I would rather do something like FullScreen WebCam does and as you mentioned show the webcam view fullscreen and overlay a bar or two with the gauges insted: https://plugins.octoprint.org/plugins/fullscreen/ I think I'll mock it up this weekend to see what makes sense.

@Ha-Z-Z-ard
Copy link
Author

Ha-Z-Z-ard commented Sep 21, 2019 via email

@StefanCohen
Copy link
Collaborator

Maybe something like this:

Screenshot 2019-09-21 at 21 21 40

@Ha-Z-Z-ard
Copy link
Author

Ha-Z-Z-ard commented Sep 21, 2019 via email

@xeddog
Copy link

xeddog commented Sep 22, 2019

Just a suggestion, but I would much rather see full screen WITHIN THE BROWSER Window. That would allow me to scale browser windows and see two or more different instances on a single screen.

@chadlichty
Copy link

Looks great!

@StefanCohen
Copy link
Collaborator

@xeddog I think I like that better than the current fullscreen. It is a bit like Octoprint TouchUI works.

Maybe something like this?

Screenshot 2019-09-22 at 08 38 42

@j7126
Copy link
Owner

j7126 commented Sep 22, 2019 •
edited

@StefanCohen That looks pretty good. I would be happy to give any help if you need.

@StefanCohen
Copy link
Collaborator

StefanCohen commented Sep 22, 2019 •
edited

@j7126 I would appreciate any help I can get with this. CSS is pretty much black magic to me.

The Idea I have is to go with the layout above (dashboard left, webcam right) when In fullscreen. That would (hopefully) not need a separate jinja template. I would like to keep the rest of the styling and compatibility with Themeify but I like your approach of placing the icons above the texts as you did with the TouchUI PR.

Maybe something like this, but I'm open for better alternatives:
Screenshot 2019-09-22 at 10 52 05

The question is what to do if there is no Webcam or if it is disabled. One approach could be to just center the dashboard and spread it out a bit horisontally.

Do you have any other suggestions? Maybe a transparent overlay like in prettygcode-viewer is better but I'm not sure: https://community.octoprint.org/t/wip-prettygcode-viewer/12169

I would really appreciate if you would like to collaborate on this.

@j7126
Copy link
Owner

j7126 commented Sep 22, 2019

I will try to do something like that, the only thing is I do not have a webcam to test with but I will try to work around that.

@StefanCohen
Copy link
Collaborator

Cool. I guess you can link to any publicly available webcam feed from a site such as opentopia or maybe just a static image. I just tried and here's one that works: http://92.60.192.245/cgi-bin/faststream.jpg?stream=full&fps=0

@jimmyeao
Copy link

@xeddog I think I like that better than the current fullscreen. It is a bit like Octoprint TouchUI works.

Maybe something like this?

Screenshot 2019-09-22 at 08 38 42

That looks awesome!

@StefanCohen StefanCohen mentioned this issue Sep 22, 2019
Closed
@j7126 j7126 mentioned this issue Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanCohen StefanCohen

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
6 participants
@jimmyeao @xeddog @chadlichty @StefanCohen @j7126 @Ha-Z-Z-ard