Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-standard and risky use of global variables #45

Open
eggplantbren opened this issue Jun 19, 2018 · 0 comments
Open

Non-standard and risky use of global variables #45

eggplantbren opened this issue Jun 19, 2018 · 0 comments
Assignees

Comments

@eggplantbren
Copy link
Collaborator

This doesn't seem to affect the functionality, and I have run kima through a valgrind check and it passes. So it is only an issue of C++ style. There are some strange uses of new to create variables on the heap and it's not clear where they get deleted. There is almost certainly a better way to manage these things.

@eggplantbren eggplantbren self-assigned this Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant