New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider models with planet identifiability #27
Comments
IMO, a much better way to go about this is to
|
By "after the fact" you mean a posteriori, after running the analysis? I have to say that I've been debating this option for quite some time. A few people asked me if kima could do this, and I'm always inclined to tell them "no because it's probably not a good idea". But then the answer is "the planet transits, we know it's there and we know its period!" |
Yes, I meant after running kima. If there is prior information about specific identified planets, I could imagine incorporating that into the kima prior by modulating the existing prior by conditioning on N>=1 and modulating the existing prior by something like exp(-0.5*pow(period[0] - p, 2)/var). |
I don't think this should be for the current release. That level of customisability will require a lot of effort put into how we are going to implement it and make it user friendly. |
I agree |
That's probably not the right word, but we might want to assign specific priors for a given planet (for the orbital period if detected with transits for example).
I started working on this adding a integer
id
argument to theRVConditionalPrior::from_uniform
andto_uniform
but:log_pdf
also needs access toid
The text was updated successfully, but these errors were encountered: