Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knip integration #36

Open
ixahmedxi opened this issue Apr 6, 2024 · 1 comment
Open

Add knip integration #36

ixahmedxi opened this issue Apr 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ixahmedxi
Copy link
Owner

Knip is an awesome tool that let's you know about unused deps/exports in the codebase, unused exports shouldn't be a worry of ours when it comes to the ui package but otherwise it does apply.

@ixahmedxi ixahmedxi added the enhancement New feature or request label Apr 6, 2024
@msmps
Copy link

msmps commented Apr 7, 2024

I had started looking at the implementation for this this afternoon, but I am currently facing some issues.

  • It fails to resolve the storybook configuration found in packages/config/storybook/src/configs/react-vite.ts that is a dependent of packages/ui/.storybook/main.ts as I can only assume knip expects all packages to be built before the command runs, which isn't ideal.
  • It fails to resolve the .css file located in the assets package, @orbitkit/assets/fonts/stylesheet.css for example, specifically when parsing apps/marketing/src/components/BaseHead.astro.
  • It finally fails to recognise the multiple eslint plugins that are used and marks them as unused, perhaps because of the monorepo nature!

I'm going to attempt to work through these following the suggestions in the documentation, but I'm hitting a couple of hurdles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants