Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 14 bug : swiping down the sheet do not pull down the sheet #116

Open
blitzvb opened this issue Sep 21, 2020 · 11 comments
Open

iOS 14 bug : swiping down the sheet do not pull down the sheet #116

blitzvb opened this issue Sep 21, 2020 · 11 comments

Comments

@blitzvb
Copy link

blitzvb commented Sep 21, 2020

Bug:

When you swipe down the view, it do not pull down gradually the sheet. When you swipe down enough it will close it suddenly. It was working great before and the bug appear only on iOS 14.

Code used :

`

    let transitionDelegate = SPStorkTransitioningDelegate()
    transitionDelegate.storkDelegate = navController
    transitionDelegate.customHeight = viewController.panelHeight
    transitionDelegate.confirmDelegate = navController
    navController.transitioningDelegate = transitionDelegate

    navController.modalPresentationStyle = .custom
    
    self.topNavigationController().present(navController, animated: true, completion: nil)`
@Amondus
Copy link

Amondus commented Oct 8, 2020

У меня аналогичная проблема в iOS 14. Будет ли исправление данного бага?

@gumenuk39
Copy link

the same

@jhk115
Copy link

jhk115 commented Oct 12, 2020

I can confirm this is also happening for me on ios 14. For me, the scroll view itself seems to be "stuck". Scrolling up does not scroll the view anymore.

@sevgjan
Copy link

sevgjan commented Nov 11, 2020

It's also happening to me, you can only see the indicator that it's moving and the opacity behind the screen is being reduced. It just dimissess the view controller if dragged down enough.

@jhk115
Copy link

jhk115 commented Nov 11, 2020

If you guys have the luxury to target iOS 13, I recommend just rolling with the native modal. It was a painless switch.

@ivanvorobei
Copy link
Owner

@jhk115 agree

@sevgjan
Copy link

sevgjan commented Nov 20, 2020

@jhk115 I agree, and for most of the part I believe we all do that. But @ivanvorobei has done an amazing job with possibilities for height customization, close button, indicator, etc. which makes us prefer to use this library.

@lyimin
Copy link

lyimin commented Dec 8, 2020

It's also happening to me only on iOS 14, solved my problem after setting it

        if #available(iOS 11.0, *) {
            tableView.contentInsetAdjustmentBehavior = .never
        } else {
            automaticallyAdjustsScrollViewInsets = false
        }

@tibo9
Copy link

tibo9 commented Dec 21, 2020

This is happening because SPStorkPresentationController containerViewWillLayoutSubviews is setting the presented view controller's frame to frameOfPresentedViewInContainerView when pan gesture changed.

@Rogue85
Copy link

Rogue85 commented Jan 23, 2022

@ivanvorobei Any updates?

@davidleee
Copy link

davidleee commented Mar 21, 2022

This is happening because SPStorkPresentationController containerViewWillLayoutSubviews is setting the presented view controller's frame to frameOfPresentedViewInContainerView when pan gesture changed.

Comment out these few lines fixes the problem. @tibo9 Did you find any side effects doing so? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants