Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CRC32 at the rootfs compression #239

Open
berlin4apk opened this issue Jul 23, 2021 · 3 comments
Open

Missing CRC32 at the rootfs compression #239

berlin4apk opened this issue Jul 23, 2021 · 3 comments

Comments

@berlin4apk
Copy link

minimal/src/10_pack_rootfs.sh

Line 18 in 4393977

find . | cpio -R root:root -H newc -o | xz -9 --check=none > $WORK_DIR/rootfs.cpio.xz

Together with the ARCH specific BJC it will maybe compress a little bit better

See also https://github.com/torvalds/linux/blob/8baef6386baaefb776bdd09b5c7630cf057c51c6/scripts/xz_wrap.sh#L23
@github-actions
Copy link

Thank you for contributing to Minimal Linux Live! :)

@ivandavidov
Copy link
Owner

Thank you, that's a really nice observation!

I'll update the initramfs generation as per your suggestions shortly.

ivandavidov added a commit that referenced this issue Jul 23, 2021
@ivandavidov
Added crc32 check and x86 BCJ (see #239)
c381971
@ivandavidov
Copy link
Owner

I've added the crc32 check, but the --x86 optimization seems to be breaking the QEMU test, so I'm leaving it for now.

sandzwerg pushed a commit to sapcc/bare-minimal-linux that referenced this issue May 17, 2022
@ivandavidov @sandzwerg
Added crc32 check and x86 BCJ (see ivandavidov#239)
9f2bbc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivandavidov @berlin4apk