Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering regression #82

Open
PHHENS opened this issue Oct 5, 2021 · 2 comments
Open

Rendering regression #82

PHHENS opened this issue Oct 5, 2021 · 2 comments

Comments

@PHHENS
Copy link

PHHENS commented Oct 5, 2021

Basic shape which rendered well with a previous version, now gives strange rendering :

 .---------.
 |.-..----.|
 || ||    ||
 || ||    ||
 |'-''----'|
 '---------'

gives
image
instead (worked in a previous version)
image

Can you please help ?
Thanks

@ivanceras
Copy link
Owner

This makes sense, due to the addition of a feature to match bigger rounded corner.
Take a look at this 3 variant example. The 3rd variant can create rounded rectangles with a bigger radius on the corners, but as a side effect, using it in the 1st figure produces this artifact as those combination is also valid and logical.
I don't have a fix for this at the moment, this may require a core overhaul such as prioritizing the closest match and ignoring the matches in which characters are farther than first match.
As a work around, perhaps add spacing to the figures such as in the 2nd example to prevent this artifact for now.

 .---------.
 |.-..----.|
 || ||    ||
 || ||    ||
 |'-''----'|
 '---------'


 .------------.
 | .-. .----. |
 | | | |    | |
 | | | |    | |
 | '-' '----' |
 '------------'


  .----------.
 | .-.  .--.  |
 | | | |    | |
 | | | |    | |
 | '-'  '--'  |
  '----------'

@PHHENS
Copy link
Author

PHHENS commented Oct 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants