Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Migrate from ECR to another templating language #4483

Open
syeopite opened this issue Mar 13, 2024 · 2 comments
Open

[Enhancement] Migrate from ECR to another templating language #4483

syeopite opened this issue Mar 13, 2024 · 2 comments
Labels
enhancement Improvement of an existing feature module:html UI issues that can't be tied to a single module type:client-side The user interface of invidious

Comments

@syeopite
Copy link
Member

Is your enhancement request related to a problem? Please describe.

ECR files are loaded at compile time. This causes two problems:

  1. A lengthily compilation time
  2. A requirement to recompile Invidious each time the templates are updated contributing to a bad developer experience.

Describe the solution you'd like

Invidious should migrate to a runtime based templating engine such as https://github.com/straight-shoota/crinja

Describe alternatives you've considered

Keep it as-is

Additional context

@syeopite syeopite added the enhancement Improvement of an existing feature label Mar 13, 2024
@SamantazFox
Copy link
Member

I wasn't aware that straight-shoota ported Jinja templates to Crystal, that's great :D
While that's low priority, moving to Jinja templates might be a good step towards community-made themes! (See #4113 (comment))

@SamantazFox SamantazFox added type:client-side The user interface of invidious module:html UI issues that can't be tied to a single module labels Apr 20, 2024
@ChunkyProgrammer
Copy link
Contributor

Is there still a way to validate that the templates don't have runtime errors at compile time? I imagine not, but I'm asking because these errors likely wouldnt be caught by the CI workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature module:html UI issues that can't be tied to a single module type:client-side The user interface of invidious
Projects
None yet
Development

No branches or pull requests

3 participants