Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect video watched status after importing from NewPipe zip data #4464

Open
kadykov opened this issue Mar 2, 2024 · 2 comments · May be fixed by #4465
Open

[Bug] Incorrect video watched status after importing from NewPipe zip data #4464

kadykov opened this issue Mar 2, 2024 · 2 comments · May be fixed by #4465
Labels
bug Something isn't working module:imports Account data import/export

Comments

@kadykov
Copy link

kadykov commented Mar 2, 2024 •
edited

Describe the bug

When exporting my data from NewPipe as a zip file and then importing it into Invidious, I've noticed that many videos from my subscriptions are marked as watched, even though I haven't actually watched them.

Here is an example data, exported from NewPipe. To keep the things simple, there is just only one subscription, and only one watched video.

Steps to Reproduce

  1. Export data from NewPipe as a zip file. If you want, you can use this example archive
  2. Import the zip file into Invidious.
  3. Observe the watched status of videos from subscribed channels.
  4. Check if there are watched videos that you didn't watch.

Screenshots
Screenshot_20240302-194926_NewPipe
Screenshot from 2024-03-02 20-15-58

Expected Behavior:
Videos should retain their correct watched status after importing from NewPipe, accurately reflecting the user's viewing history.

Actual Behavior:
Many videos from subscribed channels are incorrectly marked as watched upon importing from NewPipe, even though they haven't been viewed by the user.

Additional context
NewPipe 0.25.2
Invidious 2024.02.25-f2196898, 2024.02.19-e8a3698
@kadykov kadykov added the bug Something isn't working label Mar 2, 2024
@kadykov
Copy link
Author

kadykov commented Mar 2, 2024 •
edited

Upon inspecting the SQLite database within the zip file exported from NewPipe and subsequently confirming its validity by successfully importing it into NewPipe, I proceeded to examine the database structure.
It appears that the issue may stem from the interpretation of data within the streams table by Invidious. This table contains all available streams.

Invidious seems to interpret the items in the streams table as watch history. However, it's important to note that the actual watch history is stored in a separate table named stream_history.

@kadykov kadykov linked a pull request Mar 2, 2024 that will close this issue
Open
@SamantazFox
Copy link
Member

Thanks for the detailed issue, as well as the PR :)
I'll try to have a look at it soon(tm)!

@SamantazFox SamantazFox added the module:imports Account data import/export label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:imports Account data import/export
Projects
None yet
Milestone
No milestone
2 participants
@SamantazFox @kadykov