Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Suggest a better video player #4460

Open
Pantyhose-X opened this issue Feb 29, 2024 · 6 comments
Open

[Feature request] Suggest a better video player #4460

Pantyhose-X opened this issue Feb 29, 2024 · 6 comments
Labels
feature-request Request of a new feature

Comments

@Pantyhose-X
Copy link

Is your feature request related to a problem? Please describe.
Suggest a better video player ArtPlayer
#3246 #2187

Describe the solution you'd like

Demo https://artplayer.org/ Modify 132 lines of code

        url: 'https://raw.githubusercontent.com/Pantyhose-X/Pantyhose-X/main/subtitle.srt',

You can put hundreds of languages in a .srt file, you just need to select the languages you want to display at the same time.
It supports font color selection for each language
555555555555554

Additional context
https://github.com/zhw2590582/ArtPlayer
https://artplayer.org/document/en/

@Pantyhose-X Pantyhose-X added the feature-request Request of a new feature label Feb 29, 2024
@SamantazFox
Copy link
Member

It looks nice, however this is a huge blocking point:

The production build of artplayer.js is only compatible with the latest major version of Chrome: last 1 Chrome version
For ancient browsers, you can use the artplayer.legacy.js file, which is compatible up to: IE 11

-- https://artplayer.org/document/en/#ancient-browsers

I'd like to know more about their compatibility list, as well as the difference between their "production" and "legacy" version.

@AimiIsFat
Copy link

The demo seems to work on Firefox at least. The UX is very good in my opinion. I would very much prefer this over the current player, which does work fine but I think it could use a very big update in terms of design and UX. Just my personal opinion, though.

@Pantyhose-X
Copy link
Author

One YouTube video display multiple subtitle files at the same time.

@nirvgorilla
Copy link

I hate video players with really thin seek bars. It's like 3 pixels tall, and that's tiny for the resolution of my monitor (3840x1600). It's really annoying when you have to be so precise just to skip a video. Nah. That video player's seek bar sucks. I don't know why you think that's good. Are you running in 800x600 or something?

@Pantyhose-X
Copy link
Author

I hate video players with really thin seek bars. It's like 3 pixels tall, and that's tiny for the resolution of my monitor (3840x1600). It's really annoying when you have to be so precise just to skip a video. Nah. That video player's seek bar sucks. I don't know why you think that's good. Are you running in 800x600 or something?

You didn't try, you just posted and complained!

@nirvgorilla
Copy link

I hate video players with really thin seek bars. It's like 3 pixels tall, and that's tiny for the resolution of my monitor (3840x1600). It's really annoying when you have to be so precise just to skip a video. Nah. That video player's seek bar sucks. I don't know why you think that's good. Are you running in 800x600 or something?

You didn't try, you just posted and complained!

Actually I DID try the demo and you can see it in the screenshot above. The seek bar is super thin and is frustrating when trying to skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request of a new feature
Projects
None yet
Development

No branches or pull requests

4 participants