Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow to pause by tapping on the player screen on touch screen in Windows #4447

Closed
tomasz1986 opened this issue Feb 24, 2024 · 9 comments
Labels
enhancement Improvement of an existing feature

Comments

@tomasz1986
Copy link

tomasz1986 commented Feb 24, 2024

Is your enhancement request related to a problem? Please describe.

Among other devices, I use Invidious on a touch screen 8" Windows tablet. The play/pause button is very small, and as such it's difficult to press it with a finger.

Describe the solution you'd like

The player would be much easier to navigate with a finger if it was possible to play and pause videos simply by pressing on the screen at any place.

Describe alternatives you've considered

YouTube itself brings up its video controls on one screen press, and on the second press it pauses or unpauses the video. Because of this, it's easier to use the official YouTube video player on touch screen Windows devices than Invidious.

Additional context

The video controls themselves are very small and difficult to press on touch screen devices.

@tomasz1986 tomasz1986 added the enhancement Improvement of an existing feature label Feb 24, 2024
@tomasz1986 tomasz1986 changed the title [Enhancement] Allow to pause by clicking/tapping on any place on the player screen [Enhancement] Allow to pause by tapping on the player screen on touch screen in Windows Feb 25, 2024
@tomasz1986
Copy link
Author

I've just realised that you can actually use a mouse to click on the screen to play and pause videos. However, tapping doesn't work the same way, i.e. only the play/pause button on the bottom bar responds to touches. I didn't realise that before, because I never use this particular device with a mouse.

I've also changed the title to be about Windows only, as I can't verify what actually happens under different OSs.

@unixfox
Copy link
Member

unixfox commented Feb 25, 2024

I don't understand, if you click anywhere on the player box the video pause? Isn't that what you are looking for?

Peek.25-02-2024.18-13.mp4

@tomasz1986
Copy link
Author

tomasz1986 commented Feb 25, 2024

If you click, yes, but not if you tap with a finger… Of course, you do need a Windows touch screen device to reproduce.

Edit:

Recorded a short video.

1.mp4

@unixfox
Copy link
Member

unixfox commented Feb 25, 2024

Ha interesting, that's probably a bug in video.js. Our video player: https://github.com/videojs/video.js

Could you please try if it works better on the new video.js 8 by testing this PR: #4439?

@tomasz1986
Copy link
Author

tomasz1986 commented Feb 25, 2024

No difference, unfortunately. The only thing I can add is that if the video is already playing, then pressing on the screen does bring up the control bar (both in the current and the new video.js). However, still the only way to interact is to press on the play/pause button directly.

On YouTube, if you press once, the control bar does pop up also, however the second press pauses the video. The same is true for unpausing it.

@unixfox
Copy link
Member

unixfox commented Feb 25, 2024

does it works on the demo video.js players: https://videojs.com/?

@tomasz1986
Copy link
Author

No, it's the exact same behaviour there.

@unixfox
Copy link
Member

unixfox commented Feb 25, 2024

OK then you should create a bug report on video.js repository instead: https://github.com/videojs/video.js/issues

@tomasz1986
Copy link
Author

Reported at videojs/video.js#8608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants