Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Consider using pools for the various image requests to YouTube #4009

Open
syeopite opened this issue Jul 26, 2023 · 0 comments · May be fixed by #4326
Open

[Enhancement] Consider using pools for the various image requests to YouTube #4009

syeopite opened this issue Jul 26, 2023 · 0 comments · May be fixed by #4326
Labels
enhancement Improvement of an existing feature module:image-proxy module:pool

Comments

@syeopite
Copy link
Member

Is your enhancement request related to a problem? Please describe.

Invidious makes a lot of requests to YouTube to fetch images such as thumbnails, storyboards, etc. We should consider creating pools for these requests in order to reuse the connection and improve performance

Describe the solution you'd like

Describe alternatives you've considered

Additional context

This is mentioned a few times throughout the code. Such as:

invidious/src/invidious/routes/images.cr

Lines 56 to 59 in d956b18

# This can likely be optimized into a (small) pool sometime in the future.
HTTP::Client.get("https://yt3.ggpht.com#{url}") do |resp|
return request_proc.call(resp)
end

invidious/src/invidious/routes/images.cr

Lines 121 to 124 in d956b18

# This can likely be optimized into a (small) pool sometime in the future.
HTTP::Client.get("https://#{authority}.ytimg.com#{url}") do |resp|
return request_proc.call(resp)
end

@syeopite syeopite added the enhancement Improvement of an existing feature label Jul 26, 2023
@syeopite syeopite linked a pull request Dec 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature module:image-proxy module:pool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use connection pools when requesting images from YouTube syeopite/invidious
2 participants
@SamantazFox @syeopite