Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ligatures, json template and template cache string): add ligature support #191

Merged
merged 2 commits into from Sep 29, 2020

Conversation

mpalpha
Copy link
Contributor

@mpalpha mpalpha commented Aug 12, 2019

#174 add ligature support

@mpalpha mpalpha force-pushed the master branch 2 times, most recently from bbd045a to e71bf7e Compare August 13, 2019 20:32
@mpalpha
Copy link
Contributor Author

mpalpha commented Aug 13, 2019

#192 add json built-in template and template cache string parameter

@mpalpha mpalpha changed the title feat(ligatures): add ligature support feat(ligatures, json template and template cache string): add ligature support Aug 13, 2019
@mpalpha
Copy link
Contributor Author

mpalpha commented Aug 13, 2019

pull this project if you want to check out the changes https://github.com/mpalpha/test-fonts
use npm, and node 11+ for best results.

@efc-ls
Copy link

efc-ls commented Aug 14, 2019

#190 Hopefully he'll read this

@mpalpha
Copy link
Contributor Author

mpalpha commented Aug 14, 2019

#190 Hopefully he'll read this

just use "npm i mpalpha/webfont" until then.

…late, and templateCacheString which defaults to unix timestamp.
@Templarian
Copy link

This works with 2209 glyphs. Unfortunately anymore the TTF seems to no longer render in Chrome. The font creates [and has a much larger size]. The characters render with &#xF08A2, but not with the name, in this case `

Wondering if there is a limitation for the ligature table. The ligature relationships used in this way adds a lot to the file size (well at least for MDI which is 5k+ icons, but was only adding this for our desktop TTF).

https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6lcar.html

Our investigation... Templarian/MaterialDesign-Font#1

@Templarian
Copy link

Templarian commented Mar 23, 2020

Looked into this a bit further and the limit isn't the number of glyphs. It's a combination of the codepoints + names. 2,210 + 28,292 = 30,502, any more characters and the TTF doesn't render using ligatures.

In my font all characters increment after F0001. I'm stuck trying to figure out if this a bug or a limitation of the TTF format.

@jimmyandrade jimmyandrade added this to To do in webfont project Sep 29, 2020
@jimmyandrade jimmyandrade merged commit 42d673e into itgalaxy:master Sep 29, 2020
webfont project automation moved this from To do to Done Sep 29, 2020
@jimmyandrade jimmyandrade removed the request for review from alexander-akait September 29, 2020 21:52
@jimmyandrade jimmyandrade self-assigned this Sep 29, 2020
@jimmyandrade
Copy link
Collaborator

#190 Hopefully he'll read this

@guluws Hello, I am helping @evilebottnawi to maintain this repository. We apologize for the delay.

@jimmyandrade
Copy link
Collaborator

#190 Hopefully he'll read this

just use "npm i mpalpha/webfont" until then.

@mpalpha Does the package mpalpha/webfont still exist?
I believe that with the resumption of this project, we can join forces. Feel free to keep contributing here 😄

@jimmyandrade
Copy link
Collaborator

jimmyandrade commented Sep 29, 2020

I've accepted the PR and performed the merge with ligature and JSON support. Thank you, @mpalpha!

Looked into this a bit further and the limit isn't the number of glyphs. It's a combination of the codepoints + names. 2,210 + 28,292 = 30,502, any more characters and the TTF doesn't render using ligatures.

In my font all characters increment after F0001. I'm stuck trying to figure out if this a bug or a limitation of the TTF format.

@Templarian Thank you for bringing this context. We will plan a release and if, for some reason, in the new version, you find issues related to glyphs and ligatures, please feel free to share 😄

@jimmyandrade jimmyandrade linked an issue Sep 29, 2020 that may be closed by this pull request
@jimmyandrade jimmyandrade added this to the 10.0 milestone Sep 29, 2020
@jimmyandrade jimmyandrade linked an issue Sep 29, 2020 that may be closed by this pull request
@jimmyandrade jimmyandrade mentioned this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

feat: add a template cache string parameter feat: ligatures
4 participants