Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated media attribute #273

Open
brunocodutra opened this issue Jun 8, 2019 · 1 comment · May be fixed by #289
Open

Deprecated media attribute #273

brunocodutra opened this issue Jun 8, 2019 · 1 comment · May be fixed by #289

Comments

@brunocodutra
Copy link
Collaborator

Adapted from brunocodutra/webapp-webpack-plugin#181 (by @Scrumplex)


favicons utilizes media attributes, that are deprecated.
Example:

<link rel="apple-touch-startup-image" media="(device-width: 320px) and (device-height: 480px) and (-webkit-device-pixel-ratio: 1)" href="/apple-touch-startup-image-320x460.png">

This example contains the device-width and device-height which are both deprecated in favour of width and height. [1]

These should therefore be replaced accordingly.

Validator I used: https://validator.w3.org/nu/?doc=https%3A%2F%2Fscrumplex.net&submit=Check

@andy128k
Copy link
Collaborator

andy128k commented Nov 11, 2021

elegantapp/pwa-asset-generator#71 (comment)

Unfortunately, this is a tradeoff you have to make if you want to provide splash screens for iOS platform. As described in blog post in motivation, iOS doesn't respect Web App Manifest specs and it introduces it's own non-standard way of dealing with splash screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants