Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional properties in manifest.json #166

Open
mohsen1 opened this issue Nov 14, 2016 · 2 comments
Open

Allow additional properties in manifest.json #166

mohsen1 opened this issue Nov 14, 2016 · 2 comments

Comments

@mohsen1
Copy link

mohsen1 commented Nov 14, 2016

The manifest.json is used for a lot of things and it's hard to add new properties for each new item vendors add to it.

Right now we need gcm_sender_id, related_applications and prefer_related_applications fields in our manifest.json.

It would be nice if there was an option for adding new properties to manifest.json. It can use Object.assign or a deep extend to add those properties.

@alexander-akait
Copy link
Member

@mohsen1 Why don't use response and add properties that you need?

@ozasadnyy
Copy link

@evilebottnawi could you add some example how to do that? But in my opinion, it would be easier just to pass custom properties via settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants