Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: consistently resolve paths to absolute form #72

Merged
merged 3 commits into from Nov 17, 2019

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Nov 17, 2019

When a source-map is applied, we currently resolve to a relative path rather than an absolute path. This complicates the logic for implementing --all logic, which is concerned with collisions.

related to: bcoe/c8#158

@coveralls
Copy link

coveralls commented Nov 17, 2019

Pull Request Test Coverage Report for Build 349

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 95.759%

Totals Coverage Status
Change from base Build 340: 0.06%
Covered Lines: 502
Relevant Lines: 518

💛 - Coveralls

@bcoe bcoe merged commit 55f4116 into master Nov 17, 2019
@bcoe bcoe deleted the better-path-resolution branch November 17, 2019 02:17
@j03m
Copy link
Contributor

j03m commented Nov 17, 2019

Awesome, rebasing on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants