Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address file URL path regression on Windows #146

Merged
merged 3 commits into from Jun 3, 2021
Merged

fix: address file URL path regression on Windows #146

merged 3 commits into from Jun 3, 2021

Conversation

clemyan
Copy link
Contributor

@clemyan clemyan commented May 6, 2021

Fixes #143. This is a breaking change due to bumping of minimum supported Node version from 10.10.0 to 10.12.0.

Test results:

Test suite OS Node version Before After
c8 Windows 10 10.24.1 Failing (2) Failing (2)
c8 Windows 10 12.22.1 Passing Passing
c8 Windows 10 14.16.1 Passing Passing
c8 Windows 10 15.14.0 Failing (6) Passing
c8 Windows 10 16.1.0 Failing (6) Passing
v8-to-istanbul Windows 10 10.24.1 Failing (3) Passing
v8-to-istanbul Windows 10 12.22.1 Failing (3) Passing
v8-to-istanbul Windows 10 14.16.1 Failing (3) Passing
v8-to-istanbul Windows 10 15.14.0 Failing (3) Passing
c8 Alpine Linux (docker) 10.24.1 Passing Passing
c8 Alpine Linux (docker) 12.22.1 Passing Passing
c8 Alpine Linux (docker) 14.16.1 Passing Passing
c8 Alpine Linux (docker) 15.14.0 Passing Passing
c8 Alpine Linux (docker) 16.0.0 Passing Passing
v8-to-istanbul Alpine Linux (docker) 10.24.1 Passing Passing
v8-to-istanbul Alpine Linux (docker) 12.22.1 Passing Passing
v8-to-istanbul Alpine Linux (docker) 14.16.1 Passing Passing
v8-to-istanbul Alpine Linux (docker) 15.14.0 Passing Passing
  • The 2 failing cases in c8 WIndows Node 10.24.1 seems to be due to coverage percentages shifting slightly. Haven't look into why but does not seem to be directly related to this fix.
  • The v8-to-istanbul test suite does not run at all with Node 16 due to issue with tap@14

@@ -38,7 +38,7 @@
"tap": "^14.10.8"
},
"engines": {
"node": ">=10.10.0"
"node": ">=10.12.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 is EOL, just drop it entirely and only support 12+ since we already need to do a major?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way, but seems like @bcoe still needs Node 10 support. 🤷‍♂️ See #143 (comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah. my condolences 😀

(that said: jestjs/jest#11167 (comment))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and land this as a breaking change, I'm fine with the requirement for Node 10.12, and it means my team can keep using c8 until we drop Node 10 (hopefully in the next couple months).

@bcoe bcoe changed the title Fix file URL to path on Windows fix: address file URL path regression on Windows Jun 3, 2021
@bcoe bcoe merged commit bb04c56 into istanbuljs:master Jun 3, 2021
@bcoe
Copy link
Member

bcoe commented Jun 3, 2021

@clemyan thank you for the contribution, released in v8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken V8 source map cache file URL parsing on Windows
3 participants