fix: undefined line in branches and functions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bundling this [file](https://github.com/browserify/node-util/blob/master/util.js) with esbuild and getting the v8 coverage with playwright `_branchesToIstanbul` and `_functionsToIstanbul` hanged. These 2 functions actually should throw an error but it is swallowed for some reason. This PR just ignores if it can't find the source line for the current branch or function.
This was referenced Mar 30, 2021
bcoe
changed the title
bcoe
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bundling this file with esbuild and getting the v8 coverage with playwright
_branchesToIstanbuland_functionsToIstanbulhanged.These 2 functions actually should throw an error but it is swallowed for some reason.
This PR just ignores if it can't find the source line for the current branch or function.