Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support comment c8 ignore start/stop #130

Merged
merged 1 commit into from Dec 22, 2020

Conversation

connorjclark
Copy link
Contributor

I implemented the idea I shared here: bcoe/c8#271

/* c8 ignore start */
function dontMindMe() {
  // ...
}
/* c8 ignore stop */

I refactored the function that parses for these c8 ignore comments to have no side effects; I also split up the "on its own line" case to be handled separately from the "ignore next n" case. My goal was to make the function and its usage more readable: let me know if I failed in that goal.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connorjclark awesome, thanks for the contribution 👏

Sorry for the slow review, was driving across the country last week.

@bcoe bcoe merged commit 591126b into istanbuljs:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants