fix!: address off by one error processing branches #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an off by one error when determining blocks in v8, the first character of a block range is sometimes the
\n
from the prior line:In the example:
One of the blocks is characters 30 - 83, or:
It should not be possible for a conditional block to begin with a single character, so I believe we can address this problem by making the logic that calculates branches exclusive vs., inclusive, when it overlaps with the prior line.
Refs: bcoe/c8#254