Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istanbul-lib-report@3.0.1 introduced breaking change by updating make-dir #736

Open
pichlermarc opened this issue Jul 31, 2023 · 1 comment

Comments

@pichlermarc
Copy link

https://github.com/istanbuljs/istanbuljs/releases/tag/istanbul-lib-report-v3.0.1 introduced a breaking change by going from make-dir@^3.0.0 to make-dir@^4.0.0, as that package only supports node >= 10.

We no longer require coverage for node 8, so this is not a huge deal for us. Just wanted to open this issue as an FYI in case others have the same problem. 🙂

@ghost
Copy link

ghost commented Aug 16, 2023

This is currently breaking our node project that is still using node version 8 and using nyc for code coverage. Like @pichlermarc pointed out, this is caused by the inclusion of make-dir 4.0.0 which removed the "(_)" from their catch blocks in make-dir/index.js.

For the time being, we were able to add the following to our package.json file to make sure version 4.0.0 of make-dir was not used:

  "resolutions": {
    "make-dir": "^3.0.0"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant