Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo improvement: use npm/pnpm workspaces #703

Open
sebaplaza opened this issue Nov 2, 2022 · 4 comments · May be fixed by #704
Open

monorepo improvement: use npm/pnpm workspaces #703

sebaplaza opened this issue Nov 2, 2022 · 4 comments · May be fixed by #704

Comments

@sebaplaza
Copy link

Instead of manual script
would be great to use native monorepo utils to install npm dependencies.

We can use just npm workspaces or pnpm workspaces to manage dependencies.

This will help to have a easier way to link internal packages between them, same for bump versions.

@bcoe
Copy link
Member

bcoe commented Nov 3, 2022

sounds like a good idea 👍 would happily take a patch for this.

sebaplaza pushed a commit to sebaplaza/istanbuljs that referenced this issue Nov 3, 2022
@sebaplaza sebaplaza linked a pull request Nov 3, 2022 that will close this issue
@sebaplaza
Copy link
Author

I made a PR.

But i was thinking of CI tests, force the npm>=7 version could be a problem in matrix tests

in this case, we could install npm>=7 in CI, just to manage dependencies, but the tests will continue using the desired node version to run.

@sebaplaza
Copy link
Author

can i delete the "master" restriction in CI ?

https://github.com/istanbuljs/istanbuljs/blob/master/.github/workflows/ci.yml#L4

Like this, we can know if branches are ok.

@sebaplaza
Copy link
Author

@bcoe is ok for you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants