fix cobertura report

[bitcloud]

The cobertura reporter currently only works if it generates coverage for script files in multiple folders. If all script files are in one folder there is no package which results in not generating the right xml structure in the reports file.

To fix this I add all files in a currently called main package to collect all files residing in a single folder project. I'm still unsure about the naming, cloud be root as well, but I think main works quite well.

This should fix #66

[bitcloud]

Hey @coreyfarrell, who should I include here to move things forward? I know that the team is not that familiar with cobertura. I referenced the issue that should be closed by this.

@coderica perhaps you cloud have a look as well?

[bitcloud]

Any updates here? It would be great to get that merged. :-)

[saboya]

FYI I'm currently using this patch to provide Cobertura report in one of my projects, and it works correctly.

Link: https://dev.azure.com/saboya0915/webpack-chrome-manifest-generator-plugin/_build/results?buildId=35&view=codecoverage-tab

[bitcloud]

Thanks for the input @saboya!

[Swiftwork]

I am suspecting that Jenkins is reporting 0% coverage due to the lack of <package> and <classes> tags. @bitcloud have you verified that issue #384 won't resurface with this change? The pull-request seems more tested compared to #382, per request in #382 (comment). Would you look at merging this @bcoe and @coreyfarrell?

[bitcloud]

I am pretty sure that I covered this case with my test cases as well.

But it is impossible to be certain as #382 did not include a test case or the code the issue was based on. ;-)

[bitcloud]

@Swiftwork I should have read your comment properly...
Yes, I specifically made a testcase for that to be sure this issue doesn't reappear.

[bitcloud]

@Swiftwork perhaps you could also test the merged code in your case and add the result to this discussion?

It would be nice to see if it really fixes your issue as well and would probably add even more confidence after the #382 issue.

[Swiftwork]

@bitcloud I might get a chance on Monday, but I can confirm that when I added another folder with tests and both packages/classes tags were added, Jenkins started reporting my coverage correctly.

[bitcloud]

As you were just active, cloud you have a look here as well @coreyfarrell?

[coreyfarrell]

I don't have the capability to review anything for cobertura. We simply don't have time to go back and forth - last fix we got to this report broke other users and we had to do a second release to revert the first fix.

I'm beginning to wonder if the best thing for this report is for it to be republished by the community in a stand-alone module. istanbul-reports supports loading npm modules. For example if someone were to publish an npm module cobertura-coverage-report then you could use it with nyc report -r cobertura-coverage-report (obviously you'd need to npm install -D cobertura-coverage-report on your project for this to work).

[bcoe]

@bitcloud I'm pitching in and coming back to some old PRs. I've made it easier to release/rollback libraries from this mono-repo, so am more open to landing updates to some of these more finicky parts of the codebase.

Would you be open to rebasing?

[saboya]

Not sure if @bitcloud is still interested in this, but I rebased his commits in a fork:

https://github.com/saboya/istanbuljs/tree/develop/fix-cobertura-report

[bitcloud]

thx @saboya. To stay in this PR I just pushed your rebase in here as well.

[bcoe]

thank you for adding a test for cobertura 🎉

[bcoe]

@saboya @bitcloud I'm going to go ahead and land this 👏 thank you for the contribution.

I'm not myself a cobergtura user, so would appreciate help testing once it goes out the door -- I'll update this thread accordingly.

[bitcloud]

Your welcome! Thanks for Maintaining!
I currently have not active project which is using cobertura as well, but I will try to set dust something off to verify ;-)

[bcoe]

@saboya @bitcloud fixes are published.

[saboya]

@bcoe Not a huge project, but a personal project of mine on Azure pipelines using cobertura to report code coverage, using the new instanbul-reports version:

https://dev.azure.com/saboya0915/webpack-chrome-manifest-generator-plugin/_build/results?buildId=49&view=codecoverage-tab