Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Separate sorting for replies #1026

Open
3 tasks done
ggtylerr opened this issue May 7, 2024 · 1 comment
Open
3 tasks done

[Feature Request] Separate sorting for replies #1026

ggtylerr opened this issue May 7, 2024 · 1 comment
Labels
client (Javascript) client code and CSS improvement Not a new feature, but makes Isso more pleasant to use needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Milestone

Comments

@ggtylerr
Copy link

ggtylerr commented May 7, 2024

Checklist

  • I am running the latest version. Installing Isso from GitHub from the master branch does not fix my issue
  • I have checked the troubleshooting guide
  • I have searched the open issues, but my issue has not already been reported

What is not working?

When using the new sorting system introduced in #1005, replies are sorted the exact same as regular comments. If comments are sorted by newest first, the replies to said comments will also be sorted as such. This can potentially confuse the reader, as the reading order for threads is usually always oldest first. Here's an example of what it looks like now:
An example comment thread
Note how the thread starts with the oldest post (the OP), then immediately after that, the newest post (the reply.)

How can one reproduce this issue?

On the client-side configuration, set data-isso-sorting to newest. (This is possibly also visible in upvotes too, but haven't tested yet.) Then, post a comment, and reply to it at least twice.

@ix5 ix5 added server (Python) server code client (Javascript) client code and CSS needs-decision Architectural/Behavioral decision by maintainers needed improvement Not a new feature, but makes Isso more pleasant to use labels May 9, 2024
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
@ix5
Copy link
Member

ix5 commented May 22, 2024

My personal preference would also be to list child comments chronologically (oldest first), that's how it is done on most platforms I know which only allow for 1 level of nesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client (Javascript) client code and CSS improvement Not a new feature, but makes Isso more pleasant to use needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Projects
None yet
Development

No branches or pull requests

2 participants