Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] __refetch queries and usedRefetchQueries #74

Open
rbalicki2 opened this issue Apr 21, 2024 · 1 comment
Open

[Bug] __refetch queries and usedRefetchQueries #74

rbalicki2 opened this issue Apr 21, 2024 · 1 comment

Comments

@rbalicki2
Copy link
Collaborator

rbalicki2 commented Apr 21, 2024 •
edited

  • demonstrated in https://github.com/isographlabs/isograph/tree/rb/refetch-bug-demo-2

    Demonstrate refetch bug

    • Select set_pet_tagline in PetPhraseCard
    • In the PetDetailRoute reader, we now pass [1, 2, 3] to both PetPhraseCard and to PetBestFriendCard
    • This bug occurs because in get_nested_refetch_query_text, we compare root_path.path == *nested_refetch_query, and all three generated refetch queries pass, so we pass all of them
@rbalicki2
Copy link
Collaborator Author

I think this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbalicki2