Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially update clearfix util to be more modern #27

Open
aarongeorge opened this issue Sep 13, 2019 · 2 comments
Open

Potentially update clearfix util to be more modern #27

aarongeorge opened this issue Sep 13, 2019 · 2 comments

Comments

@aarongeorge
Copy link

I've noticed that the clearfix util is using the display: table/block method, however there is a more modern approach which is to use display: flow-root.

A demo is here showing it off.

@ismamz
Copy link
Owner

ismamz commented Sep 27, 2019

Hi @aarongeorge, I've think that in that case it's not absolutely necessary to use a mixin because you have a single property solution. A possible use case is when you need to refactor your codebase and migrate the @util clearfix to that new solution. Also, it's not fully cross-browser yet, but I'll keep this issue open to review it later.

@aarongeorge
Copy link
Author

@ismamz fair enough mate, just thought I'd leave a comment on it anyway. You make a valid point around the individual prop though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants