Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when az FM rate correction can not be computed: #136

Open
hfattahi opened this issue Oct 11, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working needs triage Issue requires triage to proceed

Comments

@hfattahi
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Describe the bug

Currently if the user asks to compute Az FM rate correction, but the computation is not possible because of lack of metadata, then the function here and here silently goes on and returns a zero LUT instead of simply throwing an exception and failing the process.

What did you expect?

If the user asks for computing AZ FM rate correction and the computation not possible because of lack of metadata I expected the reader to throw an exception and exit. The reason is that if we have two SLCs and we successfully and correctly compute the Az FM rate for one and fail to compute Az FM rate for the other but rather return ZERO LUT then we will end up with one coregistered SLC which has accounted for Az FM rate mismatch and the other which has not and therefore we would end up with significant interferometric burst discontinuities in results of artificial offsets introduced by correcting az FM rate for one SLC and not correcting for the other.

Reproducible steps

No response

Environment

No response

@hfattahi hfattahi added bug Something isn't working needs triage Issue requires triage to proceed labels Oct 11, 2023
@scottstanie scottstanie changed the title Unexpected behavior when az FM rate correction can not be comouted: Unexpected behavior when az FM rate correction can not be computed: Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Issue requires triage to proceed
Projects
None yet
Development

No branches or pull requests

2 participants