Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ignoring errors optional #148

Open
argv-minus-one opened this issue Nov 24, 2018 · 0 comments
Open

Make ignoring errors optional #148

argv-minus-one opened this issue Nov 24, 2018 · 0 comments

Comments

@argv-minus-one
Copy link

Currently, graceful-fs does two things:

  1. Recovering from errors:
  • EMFILE, EAGAIN
  • Some cases of EACCES and EPERM on Windows
  1. Ignoring certain unrecoverable errors:
  • EINVAL and EPERM from chown, lchown, and fchown
  • lutimes, lchmod, and lchown silently fail if unavailable

The former should always be safe: the requested operation does happen, just not right away. The latter, however, may or may not be safe: some applications (installers, unarchivers) don't care about chown failures, but other applications (system scripts, backup tools) do care.

Please add some way to opt out of ignoring unrecoverable errors (perhaps by moving the error recovery part into a separate module that can be required by itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant