Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should rename account for 'EBUSY' on Windows? #127

Closed
conceptualspace opened this issue May 1, 2018 · 3 comments · May be fixed by #128
Closed

should rename account for 'EBUSY' on Windows? #127

conceptualspace opened this issue May 1, 2018 · 3 comments · May be fixed by #128

Comments

@conceptualspace
Copy link

along with EACCESS and EPERM errors, EBUSY can bubble up if a file is temporarily locked in windows (for example during AV scan or Dropbox sync).

rimraf treats them the same, shouldnt graceful-fs as well?
conceptualspace added a commit to konode001/node-graceful-fs that referenced this issue May 2, 2018
@conceptualspace
win32 rename EBUSY: retry
41b336e 
when rename fails with EBUSY we should also retry like we do with EPERM and EACCESS

behaviour is consistent with rm (https://github.com/isaacs/rimraf)

resolves isaacs#127
@conceptualspace conceptualspace mentioned this issue May 3, 2018
Open
@Toilal Toilal mentioned this issue Dec 5, 2018
Closed
@jmiguel-hdez jmiguel-hdez mentioned this issue Feb 23, 2019
Closed
@deninzane
Copy link

Unlink

@zkochan
Copy link

zkochan commented Mar 14, 2023

We're having this issue in pnpm now, where we use graceful-fs

pnpm/pnpm#6201

@isaacs isaacs closed this as completed in ab32dab Mar 16, 2023
@isaacs
Copy link
Owner

isaacs commented Mar 16, 2023

This should be fixed now.

zkochan added a commit to zoli-forks/node-graceful-fs that referenced this issue Apr 4, 2023
@zkochan
fix: retry copying on EBUSY error
b67ccba 
Recently a similar fix was merged for rename isaacs#127.
But a similar issue happens on copy as well.

ref pnpm/pnpm#6201
@zkochan zkochan mentioned this issue Apr 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ebusy retry konode001/node-graceful-fs
4 participants
@isaacs @zkochan @conceptualspace @deninzane