Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-specific reference to Buffer #29

Open
pnlp-dev opened this issue Jul 19, 2020 · 2 comments
Open

Remove node-specific reference to Buffer #29

pnlp-dev opened this issue Jul 19, 2020 · 2 comments

Comments

@pnlp-dev
Copy link

exports.isBuffer = Buffer.isBuffer;

This references to Buffer makes this library incompatible in the browser because Buffer is part of the node API and is not available in the browser. Given that this library is imported by several other libraries that aim to make use of it in the browser, would you ever consider removing this reference?

Later versions of Angular (6+) have tightened their compile-time requirements to alert node-specific references like this which is why these issues are being surfaced now.

@Gozala
Copy link

Gozala commented Nov 4, 2020

Is solution proposed in #12 acceptable or is introduced dependency on buffer there is not acceptable ?

@danielehrhardt
Copy link

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants