Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort on gedit opening its unsaved changes dialog #6

Open
adlocode opened this issue Jul 26, 2022 · 0 comments · May be fixed by #10
Open

Abort on gedit opening its unsaved changes dialog #6

adlocode opened this issue Jul 26, 2022 · 0 comments · May be fixed by #10

Comments

@adlocode
Copy link
Contributor

When opening gedit, making some changes, not saving them, and then closing it, when the unsaved changes dialog should appear, instead Hopalong aborts with the following error:

hopalong: render/wlr_texture.c:26: wlr_texture_from_pixels: Assertion `width > 0' failed.
Aborted (core dumped)

Here is the backtrace:

#0  0x00007ffff788ec4c in __pthread_kill_implementation () at /lib64/libc.so.6
#1  0x00007ffff783e9c6 in raise () at /lib64/libc.so.6
#2  0x00007ffff78287f4 in abort () at /lib64/libc.so.6
#3  0x00007ffff782871b in _nl_load_domain.cold () at /lib64/libc.so.6
#4  0x00007ffff7837576 in  () at /lib64/libc.so.6
#5  0x00007ffff7b9aeab in wlr_texture_from_pixels () at /lib64/libwlroots.so.10
#6  0x0000000000409218 in hopalong_view_generate_title_texture
    (output=0x1575650, view=0x16442d0) at ../src/compositor/hopalong-view.c:209
#7  0x0000000000409415 in hopalong_view_generate_textures
    (output=0x1575650, view=0x16442d0) at ../src/compositor/hopalong-view.c:244
#8  0x000000000040628d in regenerate_textures (output=0x1575650)
    at ../src/compositor/hopalong-output.c:319
#9  0x000000000040637d in hopalong_output_frame_notify
    (listener=0x1575670, data=0x155a630)
    at ../src/compositor/hopalong-output.c:336
#10 0x00007ffff7bed3cc in wlr_signal_emit_safe () at /lib64/libwlroots.so.10
#11 0x00007ffff7af6746 in ffi_call_unix64 () at /lib64/libffi.so.8
#12 0x00007ffff7af34d2 in ffi_call_int.lto_priv () at /lib64/libffi.so.8
#13 0x00007ffff6e7fe03 in wl_closure_invoke.constprop ()
    at /lib64/libwayland-client.so.0
#14 0x00007ffff6e80573 in dispatch_event.isra ()
    at /lib64/libwayland-client.so.0
#15 0x00007ffff6e8073c in wl_display_dispatch_queue_pending ()
--Type <RET> for more, q to quit, c to continue without paging--
    at /lib64/libwayland-client.so.0
#16 0x00007ffff7baa29c in dispatch_events () at /lib64/libwlroots.so.10
#17 0x00007ffff7f933a2 in wl_event_loop_dispatch ()
    at /lib64/libwayland-server.so.0
#18 0x00007ffff7f93b05 in wl_display_run () at /lib64/libwayland-server.so.0
#19 0x0000000000405250 in hopalong_server_run (server=0x423470)
    at ../src/compositor/hopalong-server.c:172
#20 0x000000000040cfd9 in main
    (argc=1, argv=0x7fffffffdd58, envp=0x7fffffffdd68)
    at ../src/compositor/hopalong-main.c:153
TheComputerGuy96 added a commit to TheComputerGuy96/hopalong that referenced this issue Nov 13, 2022
@TheComputerGuy96
Don't generate a title texture if it's empty
458def1 
gedit has an empty title for the unsaved changes dialog,
which causes an assertion failure and a crash because of 0 width/
height (so skip texture generation if that's the case)

Fixes iridescent-desktop#6 (?)

All reported bugs should be fixed now 👀
@TheComputerGuy96 TheComputerGuy96 linked a pull request Nov 13, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't generate a title texture if it's empty TheComputerGuy96/hopalong
1 participant
@adlocode