Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_embed_svg_url needs internet connection #12281

Closed
frenzymadness opened this issue May 4, 2020 · 3 comments · Fixed by #12296
Closed

test_embed_svg_url needs internet connection #12281

frenzymadness opened this issue May 4, 2020 · 3 comments · Fixed by #12296

Comments

@frenzymadness
Copy link
Contributor

Hello.

This part of the test_embed_svg_url needs internet connection to download the SVG image from Wiki. But some build systems have internet connection disabled on purpose so this will fail.

It would be nice to have some decorator to skip tests like this when no internet connection is available. What do you think about it?

@Carreau
Copy link
Member

Carreau commented May 4, 2020

Oh.... thanks.

Yes we can do that, or my guess is SVG url= might also accept file:// url and we can point to a local one.

@Inception95
Copy link
Contributor

Hi, can I help with this question?

@Carreau
Copy link
Member

Carreau commented May 7, 2020

Yes, feel free to send a PR. I even see that the test is also mocked, so we can just remove the external test.

That would be deleting lines 109 to 112 of linked file.

@Carreau Carreau linked a pull request May 8, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants