Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select CodeMirror Keymap] Feature request: A redo shortcut for Emacs keymap #1331

Closed
dschaehi opened this issue Aug 10, 2018 · 1 comment · May be fixed by #1415
Closed

[Select CodeMirror Keymap] Feature request: A redo shortcut for Emacs keymap #1331

dschaehi opened this issue Aug 10, 2018 · 1 comment · May be fixed by #1415

Comments

@dschaehi
Copy link

I like and use the Emacs keymap a lot. What I miss is a 'redo' shortcut: somehow the Emacs keymap suppresses the existing 'redo' shortcut (i.e., Ctrl-Shift-Z or Cmd-Shift-Z) by the default keymap and does not provide an alternative. Under emacs one would press Ctrl-g and then press Ctrl-Shift-Minus to redo changes. This does not work with the Emacs keymap.
aiguofer added a commit to aiguofer/jupyter_contrib_nbextensions that referenced this issue May 15, 2019
@aiguofer
[select_keymap] Add redo shortcut for emacs keybinding
bd2d008 
Fixes ipython-contrib#1331 and shortcut will default to Ctrl-Shift-Z. Unfortunately,
the Emacs way of doing it (Ctrl-g Ctrl-Shift-Minus) isn't possible
with CodeMirror since Ctrl-g can't be used as a prefix.
@aiguofer aiguofer mentioned this issue May 15, 2019
Open
@aiguofer
Copy link
Contributor

Hey @dschaehi, sorry I had not checked for issues in a long time (the problem with a massive repo full of contributions). The problem was that CodeMirror assigns 'redo' to Ctrl-Y by default, which gets used for yank. I've gone ahead and added this to the extension and will create a PR with CodeMirror to see if it makes sense to add this there by default.

@aiguofer aiguofer mentioned this issue May 15, 2019
Merged
@dschaehi dschaehi closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[select_keymap] Add redo shortcut for emacs keybinding aiguofer/jupyter_contrib_nbextensions
2 participants
@aiguofer @dschaehi