Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out JsonSchema implementations #572

Open
bgins opened this issue Feb 13, 2024 · 0 comments
Open

Separate out JsonSchema implementations #572

bgins opened this issue Feb 13, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@bgins
Copy link
Contributor

bgins commented Feb 13, 2024

Summary

Problem

The JsonSchema derives and implementations are noisy in our source code.

Solution

Let's separate out the schemas into separate files that implement JsonSchemas for the parent modules.

Note that we should consider a mechanism to make it clear which types have JsonSchema implementations to facilitate maintenance. It should be clear when you are updating a type that will require schema changes.

@zeeshanlakhani zeeshanlakhani added the good first issue Good for newcomers label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants