Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipumsr and tidyselect 1.2.1 #71

Closed
lionel- opened this issue Mar 11, 2024 · 1 comment · Fixed by #72
Closed

ipumsr and tidyselect 1.2.1 #71

lionel- opened this issue Mar 11, 2024 · 1 comment · Fixed by #72

Comments

@lionel-
Copy link

lionel- commented Mar 11, 2024

The next version of tidyselect that I'm about to release will cause CRAN failures for ipumsr because its tests are checking for exact matches of error messages generated in tidyselect and these have now changed. Since error message contents aren't part of the tidyselect API, could you please use testthat snapshots instead?
robe2037 added a commit that referenced this issue Mar 11, 2024
@robe2037
Fixes #71; use snapshot tests for selection errors
8036f7e
@robe2037
Copy link
Collaborator

Will do—thanks for the heads-up.

@dtburk I will probably go ahead and update to testthat 3e as part of this fix.

@robe2037 robe2037 mentioned this issue Mar 11, 2024
Merged
robe2037 added a commit that referenced this issue Mar 11, 2024
@robe2037 @dtburk
Use snapshot tests in selection error messages (#72)
1a2525d 
* Fixes #71; use snapshot tests for selection errors

* Use testthat edition 3

* Update testthat snapshots

* Suggest testthat >= 3.2.0

* Update snapshots

* Require tidyselect 1.2.1 in snapshots

---------

Co-authored-by: Derek Burk <burkx031@umn.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use snapshot tests in selection error messages ipums/ipumsr
2 participants
@lionel- @robe2037