picmg led get command response misinterpreted #297

Open

PengWang-SMARTM opened this issue May 28, 2021 · 1 comment · May be fixed by #298

PengWang-SMARTM commented May 28, 2021

the "picmg led get" command result has incorrect interpretation and bad format.

# ipmitool raw 0x2c 8 0 0 1
 00 03 ff 00 02 0a 14 03 00
# ipmitool picmg led get 0 1
LED states:                                               3     [LOCAL CONTROL|OVERRIDE]
  Local Control function:     ff  [ON]
  Local Control On-Duration:  0
  Local Control Color:        2  [RED]
  Override function:     a  [ON]
  Override On-Duration:  14
  Override Color:        3  [GREEN]

The text was updated successfully, but these errors were encountered:

PengWang-SMARTM linked a pull request

that will close this issue

picmg led get: fix the interpretation and format #298

Open

Author

PengWang-SMARTM commented May 28, 2021

After patching, it should be something like:

LED states:                       3     [OVERRIDE | HAS LOCAL CONTROL]
  Local Control function:         ff    [ON]
  Local Control Color:            2     [RED]
> Override Control function:      a     [BLINKING]
  Blink On:Off Duration:          200:100 ms
  Override Control Color:         3     [GREEN]
  Lamp Test Duration:             0 ms

or

LED states:                       7     [LAMPTEST | OVERRIDE | HAS LOCAL CONTROL]
  Local Control function:         ff    [ON]
  Local Control Color:            2     [RED]
> Override Control function:      a     [BLINKING]
  Blink On:Off Duration:          200:100 ms
  Override Control Color:         3     [GREEN]
> Lamp Test Duration:             12700 ms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.