Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle non-nullable and non-optional scalar properties #83

Open
rvagg opened this issue Feb 9, 2023 · 0 comments
Open

Properly handle non-nullable and non-optional scalar properties #83

rvagg opened this issue Feb 9, 2023 · 0 comments
Assignees

Comments

@rvagg
Copy link
Member

rvagg commented Feb 9, 2023

As per discussion in ipld/ipld#268, if a struct has a map and/or list property that is not marked nullable or optional, we should expect the serialized form to have empty versions of these; I believe the current implementation will skip over them. Validation shouldn't pass if they are not present, and serialization should emit proper zero values of everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥞 Todo
Development

No branches or pull requests

1 participant