New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace fast-atomic-write with steno #285
Open
SgtPooki
wants to merge
7
commits into
test/not-same-event-loop-concurrency
Choose a base branch
from
284-chore-replace-fast-write-atomic-with-steno
base: test/not-same-event-loop-concurrency
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: replace fast-atomic-write with steno #285
SgtPooki
wants to merge
7
commits into
test/not-same-event-loop-concurrency
from
284-chore-replace-fast-write-atomic-with-steno
+10
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Dec 15, 2023
SgtPooki
changed the base branch from
main
to
test/not-same-event-loop-concurrency
April 19, 2024 18:17
SgtPooki
commented
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review after removing cached writers. code change is much smaller now @achingbrain
wemeetagain
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #284
fast-write-atomic hasn't been updated in 5 years, is CJS, and is slower than steno (updated 2 months ago).
Benchmarks for various content-types & libraries (though we only use Uint8Arrays) can be found at https://github.com/SgtPooki/fast-write-atomic#benchmarks
However, there may be further room for improvement by moving to fs.createWriteStream
Updated benchmarks of
npm run test
as of 2024-04-19