This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: exclude fs from bundle #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have 'fs' in our dep tree via ora via mock-ipfs-pinning-service but that seems to have changed. We only want to import 'fs' during node tests but esbuild tries to resolve it, so make the import dynamic.
achingbrain
force-pushed
the
fix/fix-build
branch
from
45bb4e9
to
19142a5
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 30, 2022
This was referenced Oct 16, 2022
This was referenced Oct 17, 2022
This was referenced Apr 24, 2023
This was referenced Jun 24, 2023
This was referenced Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have 'fs' in our dep tree via ora via mock-ipfs-pinning-service but that seems to have changed.
We only want to import 'fs' during node tests but esbuild tries to resolve it, so add the dummy fs package as a dev dep to the affected packages.