hashAlg option in ipfs.add does not work , it's overridden by sha2-256 algo

[fawazahmed0]

• Version:

{
  version: '0.12.2',
  commit: '6178708aedf5ea86bf537862c08db49f5b8ea20b',
  repo: '11',
  'ipfs-core': '0.12.2',
  'interface-ipfs-core': '^0.152.2'
}

• Platform:
  Windows 10, NodeJS v17.1.0

Severity:

Medium

Description:

The hashAlg option doesn't work in ipfs.add

Works Good(sha2-256 algo):

const fs = require('fs');
const path = require('path');
const IPFS =  require('ipfs-core')  

async function test() {

const ipfs = await IPFS.create({start: false})
const pathToFile = path.join(__dirname,'heart.pdf')
const stream = fs.createReadStream(pathToFile)
const { cid } = await ipfs.add(stream,{onlyHash:true,cidVersion:1,hashAlg:'sha2-256'})
console.info(cid.toString())
}
test()

Output:

bafybeic7kx44net5cnqaa7j54knakxm6dz52fv25mmhqsl4p7d7bfjb2xq

Confirmation:

ipfs add --only-hash --cid-version 1 --hash sha2-256 heart.pdf
added bafybeic7kx44net5cnqaa7j54knakxm6dz52fv25mmhqsl4p7d7bfjb2xq heart.pdf
 29.24 MiB / 29.24 MiB [====================================================================] 100.00%

Doesn't Work (blake2b-256 algo):

const fs = require('fs');
const path = require('path');
const IPFS =  require('ipfs-core')  

async function test() {

const ipfs = await IPFS.create({start: false})
const pathToFile = path.join(__dirname,'heart.pdf')
const stream = fs.createReadStream(pathToFile)
const { cid } = await ipfs.add(stream,{onlyHash:true,cidVersion:1,hashAlg:'blake2b-256'})
console.info(cid.toString())
}
test()

Output:

bafybeic7kx44net5cnqaa7j54knakxm6dz52fv25mmhqsl4p7d7bfjb2xq

Confirmation:

ipfs add --only-hash --cid-version 1 --hash blake2b-256 heart.pdf
added bafykbzaceakadezxvjej3mqeh7hjjlyd2sjkk4zn3mkmxdk6q5v2o2ccmw7ds heart.pdf
 29.24 MiB / 29.24 MiB [====================================================================] 100.00%

Thanks

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[lidel]

HTTP RPC API in go-ipfs uses hash: https://docs.ipfs.io/reference/http/api/#api-v0-add

@fawazahmed0 if you use go-ipfs on backend the workaround here is to pass hash instead of hashAlg

@achingbrain would the fix here be adding hashAlg → hash normalization to the ipfs-http-client and switching ipfs-http-server from hash-alg to hash? we should unify this.