Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: More information about the hash lookup #414

Open
andrasfuchs opened this issue Aug 7, 2019 · 13 comments
Open

Feature request: More information about the hash lookup #414

andrasfuchs opened this issue Aug 7, 2019 · 13 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@andrasfuchs
Copy link

If I enter an IPFS hash into the search field on the Explore page and click on the Explore button I got the result rather quickly if I'm lucky, but more often than not I need to sit there looking at the (nice looking) pumping-rotating three dots.

image

It would be nice to have continuous updates about the search itself to have a feel of progress. I'm not sure what is possible to show, perhaps the number of peers we asked the hash from, the number of positive or negative feedback we had from them, or the time left until potential timeout, but something meaningful would be nice.

@hacdias hacdias transferred this issue from ipfs/ipfs-desktop Aug 8, 2019
@hacdias
Copy link
Member

hacdias commented Aug 8, 2019

Hey @andrasfuchs! Thanks for the feedback. This is definitely a tricky one because we also don't have any information about the progress (as far as I know, will check). We also need to improve the loading screens on files page because of the lack of feedback.

I will investigate to see if we can get more info.

@andrasfuchs
Copy link
Author

@hacdias Thank you! Let me know if I can be any help with that.

@andrasfuchs
Copy link
Author

Hey @hacdias, did you have a chance to check if more info is available during the hash search?

@hacdias
Copy link
Member

hacdias commented Aug 19, 2019

I recently made some updates to ipld-explorer-components and I believe it is possible to get more information of the progress, but not the classic 0-100%.

@vmx, what do you think about this?

@vmx
Copy link
Member

vmx commented Aug 19, 2019

@hacdias Do you know what it makes it so slow? I'd expect that the slow thing is finding the hash/peers. So the changes to IPLD (I guess that is what you are referring to) won't help.

@hacdias
Copy link
Member

hacdias commented Aug 19, 2019

@vmx as you said, I believe it's finding the hash/peer what makes this slow. And as far as I know, there's no way to track the progress of that... Or there is?

@vmx
Copy link
Member

vmx commented Aug 19, 2019

@hacdias I don't know :)

@andrasfuchs
Copy link
Author

Is there a way to ask the go-ipfs team about this?

Do I understand it right, that we would need a continuous update about the hash/peer search progress from the daemon, preferably through the API (and probably using some streaming technology like Websockets/Socket.io)?

@hacdias
Copy link
Member

hacdias commented Aug 21, 2019

@andrasfuchs if that's a feature you'd like to have, you can open a new feature request.

@lidel
Copy link
Member

lidel commented Jan 10, 2022

@lidel lidel added help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design and removed exp/intermediate Prior experience is likely helpful labels Jan 10, 2022
@andrasfuchs
Copy link
Author

The above link is probably this: https://research.protocol.ai/blog/2021/a-visualization-tool-for-the-ipfs-dht/
;)

Copy link

welcome bot commented Dec 1, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@SgtPooki SgtPooki transferred this issue from ipfs/ipfs-webui Dec 1, 2023
@SgtPooki
Copy link
Member

SgtPooki commented Dec 1, 2023

FYI that this may not be as vital now that queries return so quickly, but for queries that ultimately time out, we may want to have some interactive display like the one mentioned at https://ipfs.io/ipfs/QmPXSyHHWqjyhrQjynzQAk4k912thZPcdBGMhsnMybcBRu/blog/2021/a-visualization-tool-for-the-ipfs-dht/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
No open projects
Status: UX Design Needed
Development

No branches or pull requests

5 participants