Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge with explore.ipld.io repo #362

Open
SgtPooki opened this issue Jun 2, 2023 · 0 comments
Open

feat: merge with explore.ipld.io repo #362

SgtPooki opened this issue Jun 2, 2023 · 0 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/beginner Can be confidently tackled by newcomers kind/architecture Core architecture of project kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jun 2, 2023

With the changes in #360, we're duplicating a lot of the logic to get a good testing environment going.

We should merge the two repos (either into this repo, or into ipld/explore.ipld.io), because:

  1. explore.ipld.io does not have any exports except the website. We have most of that in ipld-explorer-components with the changes in feat!: remove all old deps #360
  2. Maintaining two repos seems excessive at this point
  3. Exporting a library from the same repo we use to publish the component library makes using that component library mostly self documenting, instead of having it in two places (README of component library and source of explore.ipld.io)
  4. vite config and devPage.jsx and vite's index.html is duplicated in both places and really shouldn't need to be.
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Jun 2, 2023
@SgtPooki SgtPooki changed the title feat: deploy to explore.ipld.io from this repo feat: merge with explore.ipld.io repo Jun 2, 2023
@SgtPooki SgtPooki mentioned this issue Jun 2, 2023
Merged
12 tasks
@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature kind/discussion Topical discussion; usually not changes to codebase P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met kind/architecture Core architecture of project need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) exp/beginner Can be confidently tackled by newcomers effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/beginner Can be confidently tackled by newcomers kind/architecture Core architecture of project kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Prep Work / Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki