Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: image bytes are loaded twice #2217

Open
lidel opened this issue Apr 8, 2024 · 0 comments
Open

Files: image bytes are loaded twice #2217

lidel opened this issue Apr 8, 2024 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Apr 8, 2024

Tested on webui.ipfs.io and http://127.0.0.1:5001/webui/, Firefox 124.0.2 and Google Chrome 124.0.6367.18.

Opening image in Files triggers fetch twice

  • once via Kubo RPC and /api/v0/cat
  • once via subdomain gateway at cid.ipfs.localhost:port

2024-04-09-004847_1475x68_scrot

I guess we had code somewhere which should try one, and then fallback to other, but instead does both?

There is also unrelated(?) bug in Chrome where the gateway GET listed here fails (#2218)

@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant