Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new filter component on peers page should support i18n #2186

Open
SgtPooki opened this issue Dec 4, 2023 · 1 comment
Open

fix: new filter component on peers page should support i18n #2186

SgtPooki opened this issue Dec 4, 2023 · 1 comment

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Dec 4, 2023

const FilterInput = ({ setFilter, t, filteredCount }) => {
return (
<div className='flex items-center justify-between pa2'>
<input
className='input-reset ba b--black-20 pa2 mb2 db w-100'
type='text'
placeholder='Filter peers'
onChange={(e) => setFilter(e.target.value)}
/>
{/* Now to display the total number of peers filtered out on the right side of the inside of the input */}
<div className='f4 charcoal-muted absolute top-1 right-1'>{filteredCount}</div>
</div>
)
}

@SgtPooki
Copy link
Member Author

SgtPooki commented Dec 8, 2023

Also from @whizzzkid on slack:

This is beautiful [...] maybe Filter Peers could be Search Peers, because it’s not filter per se, i.e. say filtering peers with latency >25ms is not possible (yet!)

It's only filtering what peers are shown, but after Nishant said this I haven't liked "filter peers" nor "search peers".

Maybe we need something like "Find peers in table" or "search for peers in peers table"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

1 participant